The Token class, which previously was defined as a structure (though the only difference being that members are public by default instead of private), was changed to be a full class complete with access functions for all the member variables. Some additional convenience access functions were created (like checking if the code in the token is equal to a particular code).
[commit fc32a47915]
Saturday, November 3, 2012
Code (Class) Reorganization
One convention used in C++ programs are to place each major class into their own header and source file. While the source code for major classes for this project are already in separate files (table, parser and translator), all the class definitions were in a single header file and this header file was getting unwieldy.
So in preparation for all the new classes that will be added for the GUI, the major classes were separated into their own header files including the Token class with its own source file. The translator source file was also getting large, so the token handler and command handler functions were moved into their own source files with associated header files.
As part of this reorganization, many of the dated change comments were removed as these were just cluttering up the code. None of the change comments in the header file were changed, but probably should as they are taking up quite a few lines. The awk scripts also were modified since the sources of some of the enumerations were relocated and the CMake file was updated accordingly for the new files.
Several static access functions were added to the Translator class so that the token and command handler functions have access to the static values in the translator source file, which were previously accessible since these functions were in the same source file. These handlers are also accessing many other Translator internal data members (the reason they are defined as friend functions). This also should be changed, which will be done when the Translator class is transitioned.
[commit 1254b8048b]
So in preparation for all the new classes that will be added for the GUI, the major classes were separated into their own header files including the Token class with its own source file. The translator source file was also getting large, so the token handler and command handler functions were moved into their own source files with associated header files.
As part of this reorganization, many of the dated change comments were removed as these were just cluttering up the code. None of the change comments in the header file were changed, but probably should as they are taking up quite a few lines. The awk scripts also were modified since the sources of some of the enumerations were relocated and the CMake file was updated accordingly for the new files.
Several static access functions were added to the Translator class so that the token and command handler functions have access to the static values in the translator source file, which were previously accessible since these functions were in the same source file. These handlers are also accessing many other Translator internal data members (the reason they are defined as friend functions). This also should be changed, which will be done when the Translator class is transitioned.
[commit 1254b8048b]
Subscribe to:
Posts (Atom)