The Tester class contains a static options function that returned a string list of supported testing options. The constructor of the Command Line class obtained the testing options and added them to the options it supports (version and help) to generate the usage string with the program name. The testing options in the list were joined with a vertical bar ('OR') separator character using the join function of QStringList.
There was no reason to join the options in this way to generate the usage string. The options function was changed to simply return its part of the usage string (with the vertical bar characters between the testing options) as a std::string. The Command Line constructor was modified accordingly.
[branch stl commit fc61d53041] (The Qt 4.8.2 memory bug persists.)
Sunday, October 12, 2014
Command Line – Standard Argument List
The Tester class still contains functions that have an argument or return value that is a QString or QStringList that need to be changed. The first of these functions modified was the constructor that had a string list argument for the command line arguments. These arguments come from the Command Line constructor, which in turn is passed from the Main Window constructor that obtains them from the Qt application instance.
The Main Window constructor was modified to convert the QStringList arguments to a standard list of standard strings. There are Qt functions for converting lists and strings to the standard equivalents, but there is no function for converting a string list. A simple for each loop was added to iterate through the argument list and add (emplace back) to a standard list converting each element to a standard string. This list is then passed (moved) to the command line constructor.
The Command Line constructor was modified to convert the first argument (the program path name) to a base file name and store it into the program name member (which was changed to a std::string). This first element is removed from the list. The rest of the constructor was modified to treat this list and a std::list with one less element. The is version output and is help option functions were modified similarly. The program name access function was removed since there were no callers.
The Tester constructor was modified to take the program name and argument list (less program path) as separate arguments. The program name is used as the initializer of the program name member and the rest of the constructor was modified to treat this list and a std::list with one less element.
A minor bug was also discovered and corrected in the translate input function of the Tester class where the header argument was not being output when it was present. The bug was recently added when the RPN list text function was changed to a standard put stream operator function.
[branch stl commit 3d3f0d3e5c] (The Qt 4.8.2 memory bug persists.)
The Main Window constructor was modified to convert the QStringList arguments to a standard list of standard strings. There are Qt functions for converting lists and strings to the standard equivalents, but there is no function for converting a string list. A simple for each loop was added to iterate through the argument list and add (emplace back) to a standard list converting each element to a standard string. This list is then passed (moved) to the command line constructor.
The Command Line constructor was modified to convert the first argument (the program path name) to a base file name and store it into the program name member (which was changed to a std::string). This first element is removed from the list. The rest of the constructor was modified to treat this list and a std::list with one less element. The is version output and is help option functions were modified similarly. The program name access function was removed since there were no callers.
The Tester constructor was modified to take the program name and argument list (less program path) as separate arguments. The program name is used as the initializer of the program name member and the rest of the constructor was modified to treat this list and a std::list with one less element.
A minor bug was also discovered and corrected in the translate input function of the Tester class where the header argument was not being output when it was present. The bug was recently added when the RPN list text function was changed to a standard put stream operator function.
[branch stl commit 3d3f0d3e5c] (The Qt 4.8.2 memory bug persists.)
Tester – Removed Translation Calls
The rest of the translation tr() calls were removed from the Tester class, which allowed the Qt translation functions declaration macro to be removed. A number of changes were made to the Command Line class to support these changes.
The copyright statement was put into a constant C-string with a Qt translate macro, which allowed for a delayed translate call. This string contained QString style place holders for the program name (or version string for the GUI about box) and the copyright year. There was a static access function to obtain this string, which the callers filled in as desired.
These were replaced with a static copyright statement function, which internally writes to the std::ostringstream and then returns the result as a std::string. The program name or version string is no included as the caller is now responsible for this. The copyright year function used to access the year was removed and the year is used directly since this was the only user. The main window about box function was updated for this new function.
The warranty statements were put into an array of constant C-strings with Qt translate macros, which allowed for delayed translate calls. There was a static access function to obtain this array. This function was only called from the Tester class (the GUI has a different statement). These were removed and the Tester class now outputs these strings directly without translation.
While making these changes, it was noticed that the copyright year set in the CMake build file had not been updated for 2014. The application version numbers (major, minor and patch), copyright year and release string are transferred to the source code via a template input file from which CMake creates a header file. This file contained C-style preprocessor defines, which are not type-safe, and were changed to type-safe C++11 constexpr statements.
[branch stl commit d399ff535f] (The Qt 4.8.2 memory bug persists.)
The copyright statement was put into a constant C-string with a Qt translate macro, which allowed for a delayed translate call. This string contained QString style place holders for the program name (or version string for the GUI about box) and the copyright year. There was a static access function to obtain this string, which the callers filled in as desired.
These were replaced with a static copyright statement function, which internally writes to the std::ostringstream and then returns the result as a std::string. The program name or version string is no included as the caller is now responsible for this. The copyright year function used to access the year was removed and the year is used directly since this was the only user. The main window about box function was updated for this new function.
The warranty statements were put into an array of constant C-strings with Qt translate macros, which allowed for delayed translate calls. There was a static access function to obtain this array. This function was only called from the Tester class (the GUI has a different statement). These were removed and the Tester class now outputs these strings directly without translation.
While making these changes, it was noticed that the copyright year set in the CMake build file had not been updated for 2014. The application version numbers (major, minor and patch), copyright year and release string are transferred to the source code via a template input file from which CMake creates a header file. This file contained C-style preprocessor defines, which are not type-safe, and were changed to type-safe C++11 constexpr statements.
[branch stl commit d399ff535f] (The Qt 4.8.2 memory bug persists.)
Subscribe to:
Posts (Atom)