The memory issue reported for translator test 7 was the same message as test 6 except on a different line, which was another if statement. Again through the process of elimination, the statement causing the error was identified to be MID$(A$ B, which is expected to produce an expected comma error at the B token.
After briefly studying this if statement, the problem was identified and is similar to the previous problem. This if statement, in the process binary operator routine, was checking if the token (within a sub-string assignment) was not a comma. Again, it should not have been checking the token code before checking that the code was valid (since not all token types have a code). The B token is an identifier with no parentheses token type and code is not used.
The if statement was corrected by adding a check if the token has a table entry (and therefore a valid code) and it is not a comma. Now all the memory issues were resolved. I also now understand what the Conditional jump or move depends on unintialised values(s) error is indicating. Apparently, the Analyzer (valgrind) is checking for more than just memory leaks, it is also checking when a variable is being accessed, but it hasn't been initialized, which was the case for these two if statements.
Rechecking all the tests, all the memory issues were resolved. However, upon running the regression tests, translator test 7 was now failing. The problem occurred with the statement above, which was now reporting an expected operator or comma error, which was wrong because with a sub-string assignments, an operator is not allowed after the string variable identifier.
The if statement was modified so that either the token does not have a table entry or the token is not a comma. All tests now pass. To simplify (and automate) this memory testing, a new memtest script was created, but only for Linux as it requires the valgrind program. This new script is based on the regtest script and also checks the regression test results along with checking for memory issues. Now back to replacing the List class with the QList class...
[commit 1d427d7d98] [commit da0014b34d]
Subscribe to:
Post Comments (Atom)
No comments:
Post a Comment
All comments and feedback welcomed, whether positive or negative.
(Anonymous comments are allowed, but comments with URL links or unrelated comments will be removed.)