The Table class contains two internal structures, one for a table entry and one for expression information within the table entry. Only the Table class should have access to these, so their definitions were moved from the table header file to the table source file along with two constants. Only a forward reference to the table entry was left behind. Other code has no need to access these.
As a side effect, the code for all the table access functions also had to be moved to the table source file since the structure definitions were no long available in the header file. This would appear to cause an inefficiency since these functions are no longer in-line functions since they are not defined directly in the class definition. However, the GCC compiler (and probably other C++ compilers) as part of their optimization, will still in-line these small functions.
All of the table variables and functions were renamed to Qt style naming. The remaining C character definitions were changed to QString and the remaining standard library calls (and their include statements) were replaced with Qt equivalents. All the various initialized arrays used for the table entries were made static since they are only used in the table source file.
[commit e8ddccc029]
Sunday, November 4, 2012
Subscribe to:
Post Comments (Atom)
No comments:
Post a Comment
All comments and feedback welcomed, whether positive or negative.
(Anonymous comments are allowed, but comments with URL links or unrelated comments will be removed.)