The decode and translate now return RPN lists by value, either from a local variable or member variable as described in recent posts. For the functions that had an RPN list pointer as an argument, the argument was changed to a constant reference (constant because the RPN list is not modified). The callers that receive RPN lists no longer are responsible for deleting the instance, which will occur automatically when the variable goes out of scope, so all the delete calls were removed.
One issue that was discovered during compiling of functions taking a constant reference to an RPN list was an error when using the code size access function. This function only returned the code size member and did not modify the object, so it should haven declared as a constant function.
The translate input routine in the Tester class previously returned a null pointer to indicate an error. Since a pointer is no longer returned, the RPN list is cleared and an empty list is returned to indicate an error. An empty list could also mean an empty BASIC line (which is allowed), but empty lines are already being ignored and are not translated duing testing.
The null pointer initializer for the output list member was removed from the constructor of the Translator class since it is no longer a pointer - it is now initialized using the default constructor for the RPN List class. All uses accessing the pointer member were changed to regular member (dot) operators.
[branch cpp11 commit 5b9245cf0a]
Sunday, September 7, 2014
Subscribe to:
Post Comments (Atom)
No comments:
Post a Comment
All comments and feedback welcomed, whether positive or negative.
(Anonymous comments are allowed, but comments with URL links or unrelated comments will be removed.)