With the new alternate codes map implemented and partially filled with all the alternate codes for operators and internal functions, the translator was modified to start using this map instead of the associated codes array.
Two access functions were added to the table class, which included the alternate code and alternate code count functions. Both take code enumerator and operand index arguments. These functions have temporary implementations. When the new table model is fully implemented, these functions won't need the code argument as the this pointer will be used as the key to the map. They will also return a entry pointer instead of a code enumerator.
The binary operator check for a unary operator in the translator get expression routine was modified to use the new access functions. In the process internal function routine, the new access function is used to get the alternate code for a function for an operand of a different data type as the primary function code, and when an extra argument is found for a function with multiple forms.
There was an issue with the subtract code table entries. The current associated code arrays are still being used to process operands of operators because the find code routine is still being used to get associated codes for codes that don't have entries in the new alternate map yet, so couldn't be modified to use the new access functions.
The problem was caused by the change to make the main binary subtract code (two double operands) the second associated code of the negate code, which was made the primary code for minus operator. This subtract code was moved to after the subtract code with the first integer operand. Since this code was first, it was made the main binary code and the primary binary alternate to the negate code. This code did not have the correct associated codes on the current associated code array, so hidden conversion operators were incorrectly added to the output list.
This order of the alternates in the table does not matter with the alternate generation, but for the moment, the new alternate map and the associated code arrays need to agree. This problem was corrected by moving the main subtract code to before the subtract with first integer operand. Since the code enumeration is not automatic, the subtract enumerator also had to be moved to match the table. This is a temporary situation.
[branch table commit 01db8002ba]
Subscribe to:
Post Comments (Atom)
No comments:
Post a Comment
All comments and feedback welcomed, whether positive or negative.
(Anonymous comments are allowed, but comments with URL links or unrelated comments will be removed.)